feat: Use proper object serializer to handle cyclical objects #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
force-pushed
the
cyclical-objects
branch
from
dac50f0 to
f9b4a21
Compare
Codecov Report
@@ Coverage Diff @@
## master #1410 +/- ##
=========================================
Coverage ? 84.89%
=========================================
Files ? 33
Lines ? 788
Branches ? 125
=========================================
Hits ? 669
Misses ? 112
Partials ? 7
Continue to review full report at Codecov.
|
HazAT
approved these changes
Jun 25, 2018
| @@ -59,9 +137,7 @@ export function fill( | |||
| ): void { | |||
| const orig = source[name]; | |||
| source[name] = replacement(orig); | |||
| // tslint:disable:no-unsafe-any | |||
| source[name].__raven__ = true; | |||
There was a problem hiding this comment.
I missed this in a prev PR, but can we rename this to __sentry__ 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really need a "deserializer" for cyclic states and we never had it for raven-js.
However, if we'll ever need it, we should use https://github.com/WebReflection/circular-json/ or https://github.com/WebReflection/flatted