Skip to content

fix: Fixes the dsn behaviour #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2018
Merged

fix: Fixes the dsn behaviour #1411

merged 2 commits into from
Jun 26, 2018

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jun 25, 2018

This fixes the behaviour to basically support running sentry.io on a sub path like:

https://mysupercooldomain.com/sentry

@HazAT HazAT requested a review from kamilogorek as a code owner June 25, 2018 14:24
@HazAT HazAT self-assigned this Jun 25, 2018
@codecov-io
Copy link

codecov-io commented Jun 25, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@edd08f9). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1411   +/-   ##
=========================================
  Coverage          ?   84.95%           
=========================================
  Files             ?       33           
  Lines             ?      771           
  Branches          ?      122           
=========================================
  Hits              ?      655           
  Misses            ?      110           
  Partials          ?        6
Impacted Files Coverage Δ
packages/core/src/dsn.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd08f9...3886d4a. Read the comment docs.

@kamilogorek kamilogorek merged commit 1120c08 into master Jun 26, 2018
@kamilogorek kamilogorek deleted the fix/dsn branch June 26, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants