Skip to content

ci: Fix CodeQL workflow config #14117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

ci: Fix CodeQL workflow config #14117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6610ae7
Revert "chore: Don't run dependabot on CodeQL PRs (#14109)"
mydea Oct 29, 2024
549e58c
ci: Do not run CodeQL for pushes from dependabot
mydea Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ name: 'CI: CodeQL'
on:
push:
branches: [develop]
branches-ignore:
# Ignore dependabot branches
- "dependabot/**"
pull_request:
# The branches below must be a subset of the branches above
branches: [develop]
Expand All @@ -36,6 +33,8 @@ jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
# Skip for pushes from dependabot, which is not supported
if: github.event_name == 'pull_request' || github.actor != 'dependabot[bot]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, we skip pull requests? Should this be a &&?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the job runs always if it is a pull request, or else if it is not from dependabot :D this is the condition to run, not to skip ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right. Forgot how the conditional jobs work and got confused by the comment. Thanks!


strategy:
fail-fast: false
Expand Down
Loading