feat: node transports #1414
Merged
feat: node transports #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
force-pushed
the
feature/node-transport
branch
from
01be670 to
bafef7c
Compare
kamilogorek
suggested changes
Jun 26, 2018
packages/browser/src/backend.ts
Outdated
| import { supportsFetch } from '@sentry/utils/supports'; | ||
| import { Raven } from './raven'; | ||
| import { FetchTransport, XHRTransport } from './transports'; | ||
|
|
||
| /** | ||
| * Configuration options for the Sentry Browser SDK. | ||
| * @see BrowserClient for more information. | ||
| * @see BrowserClient afor more information. |
packages/browser/src/index.ts
Outdated
| @@ -27,3 +29,6 @@ export { init } from './sdk'; | |||
|
|
|||
| import * as Integrations from './integrations'; | |||
| export { Integrations }; | |||
|
|
|||
| import * as Transports from './transports'; | |||
| export { Transports }; | |||
There was a problem hiding this comment.
We can make it export { Integrations, Transports }; in one call.
| @@ -25,6 +25,12 @@ export class FetchTransport extends BaseTransport { | |||
| : '') as ReferrerPolicy, | |||
| }; | |||
|
|
|||
| return (global as Window).fetch(this.url, defaultOptions); | |||
| const response = await (global as Window).fetch(this.url, defaultOptions); | |||
There was a problem hiding this comment.
It'll break if fetch throws. We should put it in try/catch clause I guess
There was a problem hiding this comment.
Or will async wrap it in reject call? 🤔
There was a problem hiding this comment.
async handles everything 💪
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
=========================================
Coverage ? 87.15%
=========================================
Files ? 35
Lines ? 825
Branches ? 133
=========================================
Hits ? 719
Misses ? 97
Partials ? 9
Continue to review full report at Codecov.
|
kamilogorek
approved these changes
Jun 27, 2018
|
NOTE: Investigate "endless loop with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.