Skip to content

feat: Add a script for uploading browser bundles to CDN #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2018
Merged

feat: Add a script for uploading browser bundles to CDN #1424

merged 1 commit into from
Jul 4, 2018

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented Jul 3, 2018

No description provided.

@tonyo tonyo requested a review from kamilogorek as a code owner July 3, 2018 11:59
@tonyo tonyo force-pushed the feat/browser-cdn-on-gcs branch from b4aec63 to 2b890d7 Compare July 3, 2018 12:00
@tonyo tonyo requested a review from HazAT July 3, 2018 12:00
@tonyo
Copy link
Contributor Author

tonyo commented Jul 3, 2018

@HazAT is it ok to keep that script in global scripts/ dir? As an alternative we can move it to packages/browser/scripts.

@tonyo tonyo force-pushed the feat/browser-cdn-on-gcs branch from 2b890d7 to ba592e7 Compare July 3, 2018 12:04
@codecov-io
Copy link

codecov-io commented Jul 3, 2018 •
edited
Loading

Codecov Report

Merging #1424 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1424   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files          35       35           
  Lines         824      824           
  Branches      131      131           
=======================================
  Hits          720      720           
  Misses         97       97           
  Partials        7        7
Impacted Files Coverage Δ
packages/node/src/transports/base.ts 89.74% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed2461...ba592e7. Read the comment docs.

HazAT
HazAT approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🥇

@HazAT HazAT merged commit 7f08524 into master Jul 4, 2018
@HazAT HazAT deleted the feat/browser-cdn-on-gcs branch July 4, 2018 08:11
@AbhiPrasad AbhiPrasad mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyo @codecov-io @HazAT