Skip to content

ref(core): Streamline global handlers & add comments #14568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 4, 2024

This adds a comment explaining why we are using window.onerror instead of window.addEventListener('error'), for future reference.

It also removes the check for __SENTRY_LOADER__ check, which we removed quite some time ago in the Loader.

@mydea mydea requested a review from Lms24 December 4, 2024 12:20
@mydea mydea self-assigned this Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.19 KB added added
@sentry/browser - with treeshaking flags 21.87 KB added added
@sentry/browser (incl. Tracing) 35.69 KB added added
@sentry/browser (incl. Tracing, Replay) 72.59 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.02 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 76.9 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 89.39 KB added added
@sentry/browser (incl. Feedback) 39.95 KB added added
@sentry/browser (incl. sendFeedback) 27.8 KB added added
@sentry/browser (incl. FeedbackAsync) 32.59 KB added added
@sentry/react 25.87 KB added added
@sentry/react (incl. Tracing) 38.5 KB added added
@sentry/vue 27.4 KB added added
@sentry/vue (incl. Tracing) 37.51 KB added added
@sentry/svelte 23.35 KB added added
CDN Bundle 24.36 KB added added
CDN Bundle (incl. Tracing) 37.34 KB added added
CDN Bundle (incl. Tracing, Replay) 72.21 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 77.55 KB added added
CDN Bundle - uncompressed 71.6 KB added added
CDN Bundle (incl. Tracing) - uncompressed 110.88 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.95 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 237.17 KB added added
@sentry/nextjs (client) 38.79 KB added added
@sentry/sveltekit (client) 36.17 KB added added
@sentry/node 152.1 KB added added
@sentry/node - without tracing 98.98 KB added added
@sentry/aws-serverless 144 KB added added

@mydea mydea force-pushed the fn/global-handlers branch from 785a303 to 13aa5d0 Compare December 5, 2024 07:51
@mydea mydea merged commit bd94e8d into develop Dec 5, 2024
153 checks passed
@mydea mydea deleted the fn/global-handlers branch December 5, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants