Browser integration tests #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
requested changes
Aug 7, 2018
packages/browser/rollup.config.js
Outdated
| @@ -30,6 +30,32 @@ export default [ | |||
| commonjs(), | |||
| ], | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
We could de-dupe it by having this object top level, and for minified we inject uglify into plugins.
| @@ -202,8 +202,6 @@ function serializeValue<T>(value: T): T | string { | |||
|
|
|||
| /** JSDoc */ | |||
| function serializeObject<T>(value: T, depth: number): T | string | {} { | |||
| return value; | |||
kamilogorek
force-pushed
the
browser-integration-tests
branch
from
2d1a110 to
6d373bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1461 +/- ##
==========================================
- Coverage 79.68% 72.55% -7.14%
==========================================
Files 51 41 -10
Lines 2063 1246 -817
Branches 474 238 -236
==========================================
- Hits 1644 904 -740
+ Misses 409 333 -76
+ Partials 10 9 -1
Continue to review full report at Codecov.
|
kamilogorek
force-pushed
the
browser-integration-tests
branch
11 times, most recently
from
b8cc8db to
64dc00e
Compare
kamilogorek
force-pushed
the
browser-integration-tests
branch
2 times, most recently
from
24107b1 to
f3e2c36
Compare
kamilogorek
force-pushed
the
browser-integration-tests
branch
from
f3e2c36 to
1ce7c60
Compare
HazAT
approved these changes
Aug 29, 2018
HazAT
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on headless Chrome and headless Firefox.