fix(replay): Disable mousemove sampling in rrweb for iOS browsers #14937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
reviewed
Jan 8, 2025
| export function getRecordingSamplingOptions(): Partial<{ sampling: { mousemove: boolean } }> { | ||
| if ( | ||
| /iPhone|iPad|iPod/i.test(NAVIGATOR?.userAgent ?? '') || | ||
| (/Macintosh/i.test(NAVIGATOR?.userAgent ?? '') && NAVIGATOR?.maxTouchPoints && NAVIGATOR?.maxTouchPoints > 1) |
There was a problem hiding this comment.
Does this disable for desktop safari?
There was a problem hiding this comment.
No this one should just cover safari on ipad: https://stackoverflow.com/questions/60482650/how-to-detect-ipad-useragent-on-safari-browser
billyvg
approved these changes
Jan 8, 2025
c298lee
approved these changes
Jan 8, 2025
chargome
added a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the rrweb sampling options depending on the userAgent as this tends to block the main thread on iOS browsers.
closes #14534