Skip to content

add beacon transport #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/browser/src/transports/beacon.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { SentryEvent, SentryResponse, Status } from '@sentry/types';
import { getGlobalObject } from '@sentry/utils/misc';
import { serialize } from '@sentry/utils/object';
import { BaseTransport } from './base';

const global = getGlobalObject() as Window;

/** `sendBeacon` based transport */
export class BeaconTransport extends BaseTransport {
/**
* @inheritDoc
*/
public async send(event: SentryEvent): Promise<SentryResponse> {
const data = serialize(event);

const result = global.navigator.sendBeacon(this.url, data);

return {
status: result ? Status.Success : Status.Failed,
};
}
}
1 change: 1 addition & 0 deletions packages/browser/src/transports/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export { BaseTransport } from './base';
export { FetchTransport } from './fetch';
export { XHRTransport } from './xhr';
export { BeaconTransport } from './beacon';
53 changes: 53 additions & 0 deletions packages/browser/test/transports/beacon.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
import { expect } from 'chai';
import { SinonStub, stub } from 'sinon';
import { Status, Transports } from '../../src';

const testDSN = 'https://[email protected]/42';
const transportUrl = 'https://sentry.io/api/42/store/?sentry_key=123&sentry_version=7';
const payload = {
event_id: '1337',
message: 'Pickle Rick',
user: {
username: 'Morty',
},
};

let sendBeacon: SinonStub;
let transport: Transports.BaseTransport;

describe('BeaconTransport', () => {
beforeEach(() => {
sendBeacon = stub(window.navigator, 'sendBeacon');
transport = new Transports.BeaconTransport({ dsn: testDSN });
});

afterEach(() => {
sendBeacon.restore();
});

it('inherits composeEndpointUrl() implementation', () => {
expect(transport.url).equal(transportUrl);
});

describe('send()', async () => {
it('sends a request to Sentry servers', async () => {
sendBeacon.returns(true);

return transport.send(payload).then(res => {
expect(res.status).equal(Status.Success);
expect(sendBeacon.calledOnce).equal(true);
expect(sendBeacon.calledWith(transportUrl, JSON.stringify(payload))).equal(true);
});
});

it('rejects with failed status', async () => {
sendBeacon.returns(false);

return transport.send(payload).catch(res => {
expect(res.status).equal(Status.Failed);
expect(sendBeacon.calledOnce).equal(true);
expect(sendBeacon.calledWith(transportUrl, JSON.stringify(payload))).equal(true);
});
});
});
});
11 changes: 11 additions & 0 deletions packages/utils/src/supports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,17 @@ export function supportsFetch(): boolean {
}
}

/**
* Tells whether current environment supports sendBeacon API
* {@link supportsBeacon}.
*
* @returns Answer to the given question.
*/
export function supportsBeacon(): boolean {
const global = getGlobalObject();
return 'navigator' in global && 'sendBeacon' in global.navigator;
}

/**
* Tells whether current environment supports Referrer Policy API
* {@link supportsReferrerPolicy}.
Expand Down
35 changes: 35 additions & 0 deletions packages/utils/test/supports.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import * as misc from '../src/misc';
import * as supports from '../src/supports';

describe('Supports', () => {
let global: any;
let getGlobalObject: any;

beforeEach(() => {
global = {};
getGlobalObject = jest.spyOn(misc, 'getGlobalObject');
getGlobalObject.mockReturnValue(global);
});

afterEach(() => {
getGlobalObject.mockRestore();
});

describe('supportsBeacon', () => {
it('should return false if no navigator in global', () => {
expect(supports.supportsBeacon()).toEqual(false);
});

it('should return false if navigator and no sendBeacon in global', () => {
global.navigator = {};
expect(supports.supportsBeacon()).toEqual(false);
});

it('should return true if navigator and sendBeacon in global', () => {
global.navigator = {
sendBeacon: jest.fn(),
};
expect(supports.supportsBeacon()).toEqual(true);
});
});
});