fix(vue): Ensure root component render span always ends #16488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/fix-vue-root-component-span-ending
branch
from
3f505fe to
2732497
Compare
size-limit report 📦
|
s1gr1d
requested changes
Jun 6, 2025
| it.each([true, false])( | ||
| 'should finish root component span on timer after component spans end, if trackComponents is %s', | ||
| () => { | ||
| const mixins = createTracingMixins({ trackComponents: false, timeout: 1000 }); |
There was a problem hiding this comment.
M: Don't forget to include the variable from the test here at trackComponents
There was a problem hiding this comment.
oh damn, good catch, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug discovered in #16486 (comment) where the root component span would not end correctly if
trackComponentswasfalse.Also added a comment to explain the purpose of the root component
ui.vue.renderspan. We might want to look into renaming or removing this span in the future but for now, let's fix the behaviour.