-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Esm build #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Esm build #1779
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b1ce98c
Added esm build and fixed some minor issues
cromefire 5c34c3d
Fixed some ones prettier mismatch
cromefire 864bc5a
Utils es5 only
cromefire f3281a4
esm for utils and import rewrites
cromefire 2a8e2f8
improved and documented rewrite regex
cromefire 93973e4
Removed arrow function to support node 6
cromefire 71a8e46
Trying to fix node 6 problem
cromefire 7309269
Merge branch 'master' into esm
cromefire f107e62
Added readme entry
cromefire 0be9125
Merge remote-tracking branch 'origin/esm' into esm
cromefire 21eaae4
Mark as free of side-effects
cromefire 5324b64
Fixed wrong bool value for side-effects
cromefire 653f960
Merge branch 'master' into esm
cromefire 42ac8e7
Reordered .gitignore
cromefire 24e4a8d
Merge remote-tracking branch 'origin/esm' into esm
cromefire 2a60f16
Merge branch 'master' into esm
cromefire 3b1b949
Removed as default for module builds
cromefire ca63a51
Readded raven.js
cromefire b59c447
Merge branch 'master' into esm
cromefire 4e7ca18
Added esm to browser .gitignore
cromefire 47039d7
Merge remote-tracking branch 'origin/esm' into esm
cromefire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| * | ||
| !/dist/**/* | ||
| !/build/**/* | ||
| !/esm/**/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "extends": "../../tsconfig.esm.json", | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "outDir": "esm" | ||
| }, | ||
| "include": ["src/**/*"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| * | ||
| !/dist/**/* | ||
| !/esm/**/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "extends": "../../tsconfig.esm.json", | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "outDir": "esm" | ||
| }, | ||
| "include": ["src/**/*"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| * | ||
| !/dist/**/* | ||
| !/esm/**/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "extends": "../../tsconfig.esm.json", | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "outDir": "esm" | ||
| }, | ||
| "include": ["src/**/*"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| * | ||
| !/dist/**/* | ||
| !/esm/**/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "extends": "../../tsconfig.esm.json", | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "outDir": "esm" | ||
| }, | ||
| "include": ["src/**/*"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| * | ||
| !/dist/**/* | ||
| !/esm/**/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "extends": "../../tsconfig.esm.json", | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "outDir": "esm" | ||
| }, | ||
| "include": ["src/**/*"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "extends": "../../tsconfig.esm.json", | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "outDir": "esm", | ||
| "rootDir": "src" | ||
| }, | ||
| "exclude": [], | ||
| "include": ["src/**/*.ts"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| const { relative } = require('path'); | ||
| const replace = require('replace-in-file'); | ||
|
|
||
| /** | ||
| * capture group 1 | ||
| * `import/export [...] from [...]` | ||
| */ | ||
| const inExport = '(import|export)'; | ||
| /** | ||
| * capture group 2 | ||
| * Either `import {x, y, z} from [...]`, `import xyz from [...]` or `import * as xyz from [...]` | ||
| */ | ||
| const thing = '({[a-zA-Z0-9,\\s]*}| *(\\* as )?[a-zA-Z] *)'; | ||
| /** | ||
| * capture group 4 | ||
| * packages with esm modules | ||
| */ | ||
| const esmPkgs = `(${['browser', 'core', 'hub', 'minimal', 'types', 'utils'].join('|')})`; | ||
| /** | ||
| * `from '@sentry/pkg/dist/xyz';` > `from '@sentry/pkg/xyz';` | ||
| */ | ||
| const removeDist = '(/dist)?'; | ||
| /** | ||
| * capture group 6 | ||
| * `from '@sentry/pkg/xyz';` > `from '@sentry/pkg/esm/xyz';`, if not already imported from esm | ||
| */ | ||
| const subPath = '(/(?!esm)[a-zA-Z0-9/]+)?'; | ||
|
|
||
| const options = { | ||
| files: `${process.cwd()}/esm/**/*.{js,d.ts}`, | ||
| from: new RegExp(`${inExport} ${thing} from '@sentry/${esmPkgs}${removeDist}${subPath}';`, 'gm'), | ||
| to: "$1 $2 from '@sentry/$4/esm$6';", | ||
| }; | ||
|
|
||
| const changes = replace.sync(options); | ||
|
|
||
| if ('VERBOSE' in process.env) { | ||
| if (changes.length > 0) { | ||
| const esmDir = `${process.cwd()}/esm`; | ||
| console.log(`Imports rewritten to esm in:\n - ${changes.map(path => relative(esmDir, path)).join('\n - ')}`); | ||
| } else { | ||
| console.log('No imports rewritten'); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence (and the one below) sounds kinda confusing. I'd reword it somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I didn't come up with a better one, but if you have a better idea