ref: Make sure that captureMessage input is a primitive #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
jan-auer
requested changes
Jan 9, 2019
| @@ -155,7 +156,10 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement | |||
| ): Promise<SentryResponse> { | |||
| return this.buffer.add( | |||
| (async () => { | |||
| const event = await this.getBackend().eventFromMessage(message, level, hint); | |||
| const event = isPrimitive(message) | |||
| ? await this.getBackend().eventFromMessage(`${message}`, level, hint) | |||
There was a problem hiding this comment.
The other way around, I suppose?
There was a problem hiding this comment.
Also, should we instead use serialize here?
There was a problem hiding this comment.
No, this way. If it's a primitive, then capture it as a message, if complex value (obj/arr) then fallback to eventFromException. It will also handle serialization so we don't have to do it here.
jan-auer
approved these changes
Jan 9, 2019
kamilogorek
force-pushed
the
ensure-message
branch
from
b11bb48 to
7eda223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Jan's request.