fix: Revert that bundle will be appended to body #1943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
approved these changes
Mar 13, 2019
Generated by 🚫 dangerJS |
springuper
reviewed
Jun 17, 2019
| @@ -58,6 +58,7 @@ | |||
| // come out in the wrong order. Because of that we don't need async=1 as GA does. | |||
| // it was probably(?) a legacy behavior that they left to not modify few years old snippet | |||
| // https://www.html5rocks.com/en/tutorials/speed/script-loading/ | |||
| var _currentScriptTag = _document.getElementsByTagName(_script)[0]; | |||
There was a problem hiding this comment.
It cannot be null, as it's our own loader's script tag.
There was a problem hiding this comment.
Unless it's some odd edge-case scenario in non-browser environment, but you shouldn't use a loader then anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.