Add a note about window.JSON dependency #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ~~~~~~~~~~~~ | ||
|
|
||
| Raven expects the browser to provide `window.JSON` and `window.JSON.stringify`. In Internet Explorer 8+ these are available in `standards mode <http://msdn.microsoft.com/en-us/library/cc288325(VS.85).aspx>`_. | ||
| You can also use `json2.js <https://github.com/douglascrockford/JSON-js>`_ to provie the JSON implementation in browsers/modes which doesn't support native JSON |
|
Good call. I assumed this was a non-issue anymore. :) But I guess that was a poor assumption. |
|
Can you fill the typo and I'll pull in? |
Raven discards errors when window.JSON is not present. Since IE support for window.JSON is deponent on documents mode even on recent versions, it is better to let the user know about it
|
@mattrobenolt I just did :) |
mattrobenolt
added a commit
that referenced
this pull request
Apr 8, 2014
Add a note about window.JSON dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raven discards errors when window.JSON is not present. Since IE support for window.JSON is deponent on documents mode even on recent versions, it is better to let the user know about it