feat: Tracing + Reduced Bundle Size + build updates #2038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
changed the title
kamilogorek
suggested changes
May 8, 2019
kamilogorek
reviewed
May 8, 2019
| public constructor(private readonly _options: TracingOptions) { | ||
| if (!Array.isArray(_options.tracingOrigins) || _options.tracingOrigins.length === 0) { | ||
| consoleSandbox(() => { | ||
| const defaultTracingOrigins = ['localhost', /^\//]; |
There was a problem hiding this comment.
You never use it. I'd also allow for 0 length arrays, so just !Array.isArray will be now enough.
kamilogorek
approved these changes
May 8, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Tracingintegration that patches XHR and fetch to addsentry-traceheader for whitelisted urls intraceOrigins. It's still considered internal but we will ship a beta version running on sentry.io to see how it goes.