Skip to content

feat: Add logErrors option to Vue integration #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: Add logErrors option to Vue integration #2182

wants to merge 1 commit into from

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek requested a review from HazAT July 30, 2019 12:42
@kamilogorek kamilogorek mentioned this pull request Jul 30, 2019
Closed
8 tasks
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jul 30, 2019 •
edited
Loading

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES6: 15.126 kB) (ES5: 15.916 kB)

Generated by 🚫 dangerJS against bd00bb3

HazAT
HazAT requested changes Jul 31, 2019
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI + Changelog plz

@kamilogorek
Copy link
Contributor Author

Merged manually

@kamilogorek kamilogorek deleted the vue-log branch July 31, 2019 11:54
This was referenced Oct 30, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue integration silently consuming errors with no output when Sentry is disabled
3 participants
@kamilogorek @getsentry-bot @HazAT