ref: Better UnhandledRejection messages #2185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, SyntheticExceptions are no-go, as promises just don't provide stack traces, even when Error objects manually create after the fact. It'll capture Tracekit global handler only, not original calls.
This change will most likely cause some events to re-appear with better messages for some of the clients.
Setup:
Before:
After:
It'd be nice to be able to show users some info regarding using
Error
objects for rejections, but I'm almost certain we shouldn't do this in the SDK. We already have all the data we need to do this in the UI (mechanism.type
andmechanism.data.incomplete
). Not sure about this change yet though, we can iterate.