-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add support for ignoring console logging levels #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just throwing this out there for discussion? Is it a bad idea to use just a magic global for this? Or is that not a great idea. I'm imagining a general "logging config" or something like exists in other languages. I also don't write JavaScript much, which is why I'm asking. This just looks and feels really sketchy and I'm not sure of the best practices. |
Since Raven is designed to run in entirely unknown environments then I While I see where you're coming from for with regard to a general logging I think you're right that it's a little sketchy. We're relying on users I'd be happy to spend some time on that, but right now, I'm keen to just be
|
That's fair. I'd like to have more attention into plugins in general. If this solves the immediate issue you have, I'm ok with it since it doesn't change anything in raven.js itself and is purely isolated to the console plugin which very few people (afaik) use. I'd be very open to seeing a proposal for a new setup going forward. |
@dancrumb One last thing, can you rebase and squash these commits? You now have 4 extraneous commits that'll get merged with this. :) |
@dancrumb Just waiting on a rebase/squash here and it should be good to go. |
ETA ? :) |
I created #328 to replace this |
Users just add a
pluginOptions
object to the Raven object: