Skip to content

feat: Vue performance monitoring #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2020
Merged

feat: Vue performance monitoring #2571

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5ec5db
feat: Vue performance monitoring
kamilogorek May 6, 2020
a72bc6a
Code review updates
kamilogorek May 7, 2020
c4f46e0
Make linters happy
kamilogorek May 7, 2020
4df15af
Remove apm as dependency, make tracing default w. integration
kamilogorek May 11, 2020
6b11742
changelog
kamilogorek May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/integrations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"module": "esm/index.js",
"types": "dist/index.d.ts",
"dependencies": {
"@sentry/apm": "5.15.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this is interesting. How does it affect bundle size?
How does it impact users of the integrations that don't use @sentry/apm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't if you are not using Vue. It'll be fetched though.
I was thinking about passing apm's Tracing integration as a parameter, buuut not sure if it's worth it just yet.

"@sentry/types": "5.15.5",
"@sentry/utils": "5.15.5",
"tslib": "^1.9.3"
Expand Down
Loading