Skip to content

fix: Send event timestamp #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

rhcarvalho
Copy link
Contributor

Fixes #2573.

@rhcarvalho rhcarvalho requested a review from kamilogorek as a code owner May 7, 2020 12:44
@rhcarvalho
Copy link
Contributor Author

Moved lines around just to sort alphabetically.

@rhcarvalho rhcarvalho merged commit e7bf856 into getsentry:master May 7, 2020
@rhcarvalho rhcarvalho deleted the event-timestamp branch May 7, 2020 13:30
@thinkocapo
Copy link

thinkocapo commented May 31, 2020

@rhcarvalho I like that timestamp is set now.

One thing I noticed, it looks like the js event gets timestamped in format 1590946750.683085

But I'm pretty sure that sentry-python timestamps too but it's in format 2020-05-31T11:10:29.118356Z

Is there one that's preferred? It looks like we support both
https://develop.sentry.dev/sdk/event-payloads/properties/span_timestamp/

Update - I found on Transactions there's a start_timestamp and a timestamp and I've developed program to handle Errors vs Transactions. I realized updating timestamps (while pulling events out of a database for making them real-time again) is easy on Errors because on Transactions I think there's a Start+Stop (start_timestamp, timestamp)

I'm good from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set timestamp of events before sending
3 participants