ci: Run browserstack tests only if key is present #2576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For PRs from external contributors, browserstack tests can never succeed because they depend on secret env var keys that Travis do not provide to untrusted builds. This change disables running the tests altogether when the keys are not available. The browserstack tests are run anyway in master and release branches, no changes.
HazAT
approved these changes
May 8, 2020
kamilogorek
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PRs from external contributors, browserstack tests can never succeed
because they depend on secret env var keys that Travis do not provide to
untrusted builds.
This change disables running the tests altogether when the keys are not
available.
The browserstack tests are run anyway in master and release branches, no
changes.