Skip to content

misc: Remove raven-js and raven-node from master #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2020

Conversation

rhcarvalho
Copy link
Contributor

@rhcarvalho rhcarvalho commented May 20, 2020

We track raven-js and raven-node (v3 of JS SDKs) and release important bugfixes only from the '3.x' branch, and never from master.

Over time, the code in raven-* in master and in the 3.x branch got out of sync.

Removing raven-* from master eliminates confusion and cleans up the workspace when developing the current 5.x series of packages.

@getsentry-bot
Copy link
Contributor

getsentry-bot commented May 20, 2020

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.7773 kB) (ES6: 15.8076 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 7a81705

@rhcarvalho rhcarvalho changed the title misc: Remove raven-js from master misc: Remove raven-js and raven-node from master May 26, 2020
@rhcarvalho rhcarvalho force-pushed the rhcarvalho/remove-raven-from-master branch from cdb450c to 9c8fc2c Compare May 26, 2020 15:30
We track raven-js (v3 series of JS SDKs) and release important bugfixes
only from the '3.x' branch, and never from master.

Over time, the code in raven-js in master and in the 3.x branch got out
of sync.

Removing raven-js from master eliminates confusion and cleans up the
workspace when developing the current 5.x series of packages.
The package is maintained in the '3.x' branch, not master.
@rhcarvalho rhcarvalho force-pushed the rhcarvalho/remove-raven-from-master branch from 9c8fc2c to 4ec10a9 Compare May 26, 2020 15:36
@rhcarvalho
Copy link
Contributor Author

This is the result of

$ git rm -r packages/raven-js packages/raven-node

Plus changes to remove lines from a handful of files:

$ git diff --stat HEAD~2
 .gitignore    | 1 -
 lerna.json    | 1 -
 package.json  | 1 -
 tsconfig.json | 4 +---
 typedoc.js    | 2 --
 yarn.lock     | 7 -------
 6 files changed, 1 insertion(+), 15 deletions(-)

@rhcarvalho rhcarvalho marked this pull request as ready for review May 26, 2020 15:40
@rhcarvalho rhcarvalho requested a review from kamilogorek as a code owner May 26, 2020 15:40
@rhcarvalho
Copy link
Contributor Author

While not the most important reason for removal, it does reduce the amount of stuff in disk in a checkout.
Also makes global searches and search-replace more useful.

Before

$ git checkout master
$ du -hc $(git ls) | tail -1        # let's ignore the quoting problem missing one file in the total
du: packages/raven-node/test/fixtures/file: No such file or directory
du: with: No such file or directory
du: spaces: No such file or directory
du: in: No such file or directory
du: path.js: No such file or directory
8.6M    total

After

$ git checkout rhcarvalho/remove-raven-from-master
$ du -hc $(git ls) | tail -1
2.5M    total

Removing raven-* brings us to a checkout which is 29% of the previous size.
A reduction of over 70% 😄

@kamilogorek
Copy link
Contributor

image

@rhcarvalho
Copy link
Contributor Author

Cancelled the BrowserStack job since it should be irrelevant here. All the other jobs are green.

image

@rhcarvalho rhcarvalho merged commit 610ff22 into master May 27, 2020
@rhcarvalho rhcarvalho deleted the rhcarvalho/remove-raven-from-master branch May 27, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants