-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
misc: Remove raven-js and raven-node from master #2604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdb450c
to
9c8fc2c
Compare
We track raven-js (v3 series of JS SDKs) and release important bugfixes only from the '3.x' branch, and never from master. Over time, the code in raven-js in master and in the 3.x branch got out of sync. Removing raven-js from master eliminates confusion and cleans up the workspace when developing the current 5.x series of packages.
The package is maintained in the '3.x' branch, not master.
9c8fc2c
to
4ec10a9
Compare
This is the result of $ git rm -r packages/raven-js packages/raven-node Plus changes to remove lines from a handful of files: $ git diff --stat HEAD~2
.gitignore | 1 -
lerna.json | 1 -
package.json | 1 -
tsconfig.json | 4 +---
typedoc.js | 2 --
yarn.lock | 7 -------
6 files changed, 1 insertion(+), 15 deletions(-) |
While not the most important reason for removal, it does reduce the amount of stuff in disk in a checkout. Before$ git checkout master
$ du -hc $(git ls) | tail -1 # let's ignore the quoting problem missing one file in the total
du: packages/raven-node/test/fixtures/file: No such file or directory
du: with: No such file or directory
du: spaces: No such file or directory
du: in: No such file or directory
du: path.js: No such file or directory
8.6M total After$ git checkout rhcarvalho/remove-raven-from-master
$ du -hc $(git ls) | tail -1
2.5M total Removing raven-* brings us to a checkout which is 29% of the previous size. |
kamilogorek
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We track raven-js and raven-node (v3 of JS SDKs) and release important bugfixes only from the '3.x' branch, and never from master.
Over time, the code in raven-* in master and in the 3.x branch got out of sync.
Removing raven-* from master eliminates confusion and cleans up the workspace when developing the current 5.x series of packages.