Skip to content

Revert "feat: Require use of flag to send envelopes (#2594)" #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented May 25, 2020

This reverts commit 0d9725a.

The endpoint works now and we should use it going forward, no option.

@HazAT HazAT requested a review from rhcarvalho May 25, 2020 11:28
@HazAT HazAT requested a review from kamilogorek as a code owner May 25, 2020 11:28
@HazAT HazAT self-assigned this May 25, 2020
@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.8418 kB) (ES6: 15.8799 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against ea9bd46

@rhcarvalho
Copy link
Contributor

Do we need to rush removing this? I'd rather have a quick way out in Sentry in case we run into any problems in the coming weeks, without requiring changes to the SDK.

Then we have time to plan the switch better. There could be more issues than what @dashed found in #2602.

Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd wait a few more weeks.

@HazAT
Copy link
Member Author

HazAT commented May 25, 2020

Waiting gives us little benefit, the chances of us uncovering a breaking bugs are low. This almost ran for over a week on sentry.io
We need to send transactions through envelopes sooner rather than later to potentially uncover more. If something new comes up we fix it on the way but I don't see any blocking issue right now even this breadcrumb issue Alberto raised.

Since AM / Tracing is considered a beta feature overall this is fine.

@dashed
Copy link
Member

dashed commented May 25, 2020

I think it’ll be fine. We’ll be able to surface more issues soon.

@HazAT
Copy link
Member Author

HazAT commented May 26, 2020

I would go ahead and merge this for the said reasons
cc @rhcarvalho

@rhcarvalho rhcarvalho dismissed their stale review May 26, 2020 16:40

I'm minority on wanting to wait

@HazAT HazAT merged commit f1f0924 into master May 27, 2020
@HazAT HazAT deleted the hazat/revert-envelope-option branch May 27, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants