-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Additional migration notes from raven-js #2629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A few important keys were renamed (such as `shouldSendCallback`) without any notice in the docs. Additionally, this commit adds links to the appropriate documentation pages so the user can learn more about how to use new features, such as `withScope`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed a few small oversights
Thanks for the help :)
_Old_: | ||
|
||
```js | ||
Sentry.init({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentry.init({ | |
Raven.config('___PUBLIC_DSN___', { |
_Old_: | ||
|
||
```js | ||
Sentry.init({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentry.init({ | |
Raven.config('___PUBLIC_DSN___', { |
_Old_: | ||
|
||
```js | ||
Sentry.init({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentry.init({ | |
Raven.config('___PUBLIC_DSN___', { |
``` | ||
|
||
_New_: | ||
|
||
```js | ||
Raven.captureMessage('test1', 'info'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raven.captureMessage('test1', 'info'); | |
Sentry.captureMessage('test1', 'info'); |
I forgot to press "apply suggestions" 🤦 |
Fixed here: 114ce0e |
Whoops, thanks for correcting my mistake there. I was focused on the
property names and not the init method!
…On Tue, Jun 2, 2020, 7:07 AM Kamil Ogórek ***@***.***> wrote:
Fixed here: 114ce0e
<114ce0e>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2629 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJEKP7RYFYMGFWJMWKXSATRUTMPHANCNFSM4NOLNAEQ>
.
|
Hey folks. Wanted to:
|
Thanks @comp615 for mentioning this. Since you're so recently aware of what is missing, would you mind adding a PR for the new docs? |
Unfortunately I can't do that since I haven't figured out what to do with them yet lol :-/ Seems like ideally someone who makes the SDK or works at Sentry would be a good candidate to help on that front. EDIT: UnhandledRejections: #2019 |
Ah I see. Well:
|
Aha, thank you! I ended up just getting rid of what we were doing in |
A few important keys were renamed (such as
shouldSendCallback
) withoutany notice in the docs.
Additionally, this commit adds links to the appropriate documentation pages
so the user can learn more about how to use new features, such as
withScope
.