Skip to content

Additional migration notes from raven-js #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

STRML
Copy link
Contributor

@STRML STRML commented May 29, 2020

A few important keys were renamed (such as shouldSendCallback) without
any notice in the docs.

Additionally, this commit adds links to the appropriate documentation pages
so the user can learn more about how to use new features, such as withScope.

A few important keys were renamed (such as `shouldSendCallback`) without
any notice in the docs.

Additionally, this commit adds links to the appropriate documentation pages
so the user can learn more about how to use new features, such as `withScope`.
@STRML STRML requested a review from kamilogorek as a code owner May 29, 2020 21:11
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a few small oversights
Thanks for the help :)

_Old_:

```js
Sentry.init({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sentry.init({
Raven.config('___PUBLIC_DSN___', {

_Old_:

```js
Sentry.init({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sentry.init({
Raven.config('___PUBLIC_DSN___', {

_Old_:

```js
Sentry.init({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sentry.init({
Raven.config('___PUBLIC_DSN___', {

```

_New_:

```js
Raven.captureMessage('test1', 'info');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Raven.captureMessage('test1', 'info');
Sentry.captureMessage('test1', 'info');

@kamilogorek kamilogorek merged commit 8ec79f1 into getsentry:master Jun 2, 2020
@kamilogorek
Copy link
Contributor

I forgot to press "apply suggestions" 🤦

@kamilogorek
Copy link
Contributor

Fixed here: 114ce0e

@STRML
Copy link
Contributor Author

STRML commented Jun 2, 2020 via email

@comp615
Copy link

comp615 commented Jun 18, 2020

Hey folks. Wanted to:

  1. Thank you for adding this, it was frustrating trying to migrate with incomplete docs.
  2. Let you know that both captureUnhandledRejections and dataCallback seem to be missing in the migration information still

@STRML STRML deleted the patch-1 branch June 18, 2020 16:20
@STRML
Copy link
Contributor Author

STRML commented Jun 18, 2020

Thanks @comp615 for mentioning this. Since you're so recently aware of what is missing, would you mind adding a PR for the new docs?

@comp615
Copy link

comp615 commented Jun 18, 2020

Unfortunately I can't do that since I haven't figured out what to do with them yet lol :-/ Seems like ideally someone who makes the SDK or works at Sentry would be a good candidate to help on that front.

EDIT: UnhandledRejections: #2019

@STRML
Copy link
Contributor Author

STRML commented Jun 18, 2020

Ah I see. Well:

@comp615
Copy link

comp615 commented Jun 18, 2020

Aha, thank you! I ended up just getting rid of what we were doing in dataCallback so that's probably for the best. Will try out the integration approach. Appreciate the help, and I see they did add that to the full docs as well. Just had trouble finding it :-/

@kamilogorek
Copy link
Contributor

@comp615 @STRML thanks for pointing that out. Added both things: #2693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants