Skip to content

Remove includes in favor or indexOf for IE support #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

Remove includes in favor or indexOf for IE support #2683

merged 1 commit into from
Jun 18, 2020

Conversation

kamilogorek
Copy link
Contributor

Fixes #2681

@kamilogorek kamilogorek requested review from HazAT and a team and removed request for HazAT June 18, 2020 11:45
rhcarvalho
rhcarvalho approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super IE11

@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.0986 kB) (ES6: 16.1699 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 913e9b0

@kamilogorek kamilogorek merged commit b449f5d into master Jun 18, 2020
@kamilogorek kamilogorek deleted the drop-includes branch June 18, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracing Code uses String.includes (unsupported in IE11)
3 participants
@kamilogorek @getsentry-bot @rhcarvalho