Skip to content

build: Add @sentry/react and @sentry/gatsby to release registry #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

build: Add @sentry/react and @sentry/gatsby to release registry #2758

merged 1 commit into from
Jul 21, 2020

Conversation

rhcarvalho
Copy link
Contributor

Packages that report themselves as SDKs shall be part of the registry:

https://github.com/getsentry/sentry-release-registry/

@rhcarvalho rhcarvalho requested a review from a team July 21, 2020 14:06
@rhcarvalho rhcarvalho requested a review from kamilogorek as a code owner July 21, 2020 14:06
@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.2363 kB) (ES6: 16.3525 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 9bedfa1

@github-actions
Copy link
Contributor

size-limit report

Path Size Loading time (3g) Running time (snapdragon) Total time
@sentry/browser - CDN Bundle (gzipped) 17.64 KB (+0.01% 🔺) 353 ms (+0.01% 🔺) 722 ms (+57.15% 🔺) 1.1 s
@sentry/browser - Webpack 18.39 KB (0%) 368 ms (0%) 517 ms (-0.61% 🔽) 885 ms
@sentry/react - Webpack 18.39 KB (0%) 368 ms (0%) 707 ms (+35.32% 🔺) 1.1 s
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.57 KB (0%) 452 ms (0%) 289 ms (-14.65% 🔽) 741 ms

@rhcarvalho
Copy link
Contributor Author

Is the craft config part of the bundle?
image

@rhcarvalho rhcarvalho merged commit 33a414f into master Jul 21, 2020
@rhcarvalho rhcarvalho deleted the rhcarvalho/craft-registry-react-gatsby branch July 21, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhcarvalho @getsentry-bot @kamilogorek