Serverless integration for AWS Lambda - NodeJS #2865
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarvasekar7700
commented
Aug 31, 2020
amarvasekar7700
commented
- Added awslambda.ts file in the integrations folder. In contains new integration for AWS Lambda for NodeJS.
- Added AWSLambda integration in index.ts file.
- Added new packages in package.json file.
kamilogorek
reviewed
Aug 31, 2020
kamilogorek
suggested changes
Aug 31, 2020
kamilogorek
suggested changes
Sep 1, 2020
HazAT
requested changes
Sep 4, 2020
Comment on lines
108
to
110
| Name: 'node', | ||
| // global.process.version return the version of node | ||
| Version: global.process.version, |
There was a problem hiding this comment.
Suggested change
| Name: 'node', | |
| // global.process.version return the version of node | |
| Version: global.process.version, | |
| name: 'node', | |
| // global.process.version return the version of node | |
| version: global.process.version, |
We usually never capitalize keys, or is there a specific reason doing so?
There was a problem hiding this comment.
Changes are made in the file but not reflecting.
| * @hidden | ||
| */ | ||
| const setAdditionalRuntimeData = (scope: Scope): void => { | ||
| scope.setContext('Runtime', { |
There was a problem hiding this comment.
Suggested change
| scope.setContext('Runtime', { | |
| scope.setContext('runtime', { |
There was a problem hiding this comment.
Changes are made in the file but not reflecting.
…les. 2. Added awsLambdaPrelude.ts and setup.json files for creating development package. 3. Added fs module in package.json for unit test case.
|
Closed in favor of #2886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.