in the AMD case, reveal the global right away

[mwcz]

This is to accomodate synchronous code that might be running alongside AMD modules. The AMD case already exposes the window.Raven global, however previous to this patch it waited until the AMD module was specified as a dependency before initializing the global.

I figure that if the global is going to be exposed in the AMD case, it
may as well happen right away, so non-AMD code can depend on it being
there. :)

[mattrobenolt]

lol Jesus.

Serious question here because I don't work in this space: why isn't there just a copy/paste thing that every library does? We've gone back and forth on this like, 10 times now.

[mwcz]

Sorry, I didn't know the history! Here's my take on this specific issue:

If someone's code is entirely in AMD format, they'll never need the window.Raven global. Contrarily, if none of their code is AMD, they'll get the global.

But in the project I work on, some code is AMD, and some isn't, so it makes sense (for me) to expose the global and register the AMD module. Raven's already doing that, cha-ching, except it doesn't expose the global until the AMD module has been requested with a require(['raven']) call. If the global is going to be exposed so that synchronous code can use it, it shouldn't be reliant on asynch code to establish the global.

If you'd like to use jQuery as an example, they register an AMD module and expose a global separately.

I wish there was just One Right Way too... I guess it's because JS has never had a module system, so people invented them (hence "14 competing standards" syndrome). That legacy of suckage has a cost. You've gotta accomodate a wide variety of historical abuses and competing module standards if you want to appeal to the widest audience. ES6 introduces a real module system, but the older module system's aren't going to vanish overnight. Can you imagine if Python had four different types of import?

if pmd:
    pmd.load(mymodule)
elif pypack:
    ppyack.include(mymodule)
elif require:
    require.once(mymodule)
else:
    import mymodule

lol indeed

[mattrobenolt]

I agree with this to not break backwards compatibility.