Skip to content

ref(node): Don't strip query strings or fragments from span descriptions #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2020
Merged

ref(node): Don't strip query strings or fragments from span descriptions #2882

merged 3 commits into from
Sep 10, 2020

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Sep 7, 2020 •
edited
Loading

Reverts the span half of #2857, which added the stripping.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2020 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.69 KB (0%)
@sentry/browser - Webpack 18.51 KB (0%)
@sentry/react - Webpack 18.51 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 23.47 KB (-0.01% 🔽)

@lobsterkatie lobsterkatie force-pushed the kmclb-put-query-string-back-in-span-name branch from e6a572d to c9848e9 Compare September 9, 2020 20:27
@lobsterkatie lobsterkatie marked this pull request as ready for review September 9, 2020 21:46
HazAT
HazAT approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't do this in browser? 🤔

@lobsterkatie
Copy link
Member Author

We didn't do this in browser? 🤔

Doesn't apply in browser. The transaction name is set here (and I checked - pathname already doesn't have the query string or fragment, so there's nothing to trim), and the span description is set here and here, where we never added trimming.

@lobsterkatie lobsterkatie merged commit 48ad138 into master Sep 10, 2020
@lobsterkatie lobsterkatie deleted the kmclb-put-query-string-back-in-span-name branch September 10, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobsterkatie @HazAT