ref(node): Make naming of http
method wrappers clearer
#2883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is purely cosmetic, but hopefully will make the code easier to read.
Two issues here:
Typing a function which returns a function which takes a function and returns a function can get a little dizzying in TS, whether in the writing or the reading. Parentheses would help some, but Prettier removes them. Better to break up the endless chain of
( ): ( ) => ( ): ( ) => ( ): ( ) => ( ): ( ) => ( ): ( ) => ( ): ( ) => ( ): ( ) => ( ): ( ) => ( )
(I'm exaggerating, but you get the point) with some named types, both so it's clearer what belongs to what but also so it's more obvious what each bit is for.The word "wrapper" in English is ambiguous, in that it can mean either the entity doing the wrapping or the outer layer which said entity applies to the wrapped item. To add to the confusion, we (English speakers) sometimes employ a synecdoche and refer to to the wrapped item as a "wrapper," because even though both wrapper and wrappee are there, you can only see the wrapper. Mad props to anyone who has to learn our ridiculous tongue.
The end result here is a tiny bit awkward-sounding, but hopefully easier to parse and harder to get misled by.