Skip to content

fix(types): Remove redundant implementee #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Oct 1, 2020

The Span interface extends the SpanContext interface, so anything in the latter is definitely in the former. Therefore, implementing the "superset" interface is sufficient.

@lobsterkatie lobsterkatie force-pushed the kmclb-redundant-span-implementee branch from cd190d0 to c786183 Compare October 1, 2020 21:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2020

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 18.06 KB (+0.01% 🔺)
@sentry/browser - Webpack 18.88 KB (0%)
@sentry/react - Webpack 18.88 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 23.94 KB (+0.01% 🔺)

@lobsterkatie lobsterkatie merged commit 62624bd into master Oct 2, 2020
@lobsterkatie lobsterkatie deleted the kmclb-redundant-span-implementee branch October 2, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants