serverless: let reject in callbackWrapper call captureExceptionAsync with the error #2958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2956
I modified
fakeCallback
to not return the supplied error. I don't think you can assume that callbacks will always do that. That exposes the bug in the existing test suites if we add a check:Second commit fixes the issue by discarding the
callback
result andreject
ing with the error instead.yarn lint
) & (yarn test
).