Improve the capture of unhandled errors from promises #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using the code behind #319 for about a week, we ran into a little problem.
Even though it's recommended that
Promise.reject
passes in anError
instance, not all 3rd-party libraries do. This lead to production errors with[object Object]
as the error message, which wasn't very helpful.This fixes the problem by creating a new error (for the stack trace), if one wasn't provided, and passing the
reason
object asextra
context.