Skip to content

feat: Add runtime tags to Next.js errors #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

iker-barriocanal
Copy link
Contributor

@iker-barriocanal iker-barriocanal commented Mar 15, 2021

Add a new tag runtime on the frontend with the value browser and the backend with the value node for the Next.js SDK.

Other minor changes:

  • Some errors captured by the plugin are not actual errors and contain unuseful and/or misleading data. To avoid this, only actual errors are captured as exceptions, and the others are captured as messages.
  • Remove unused @sentry/minimal package.
  • Remove undefined args from on-error-client in the plugin.

The tags are added to help users identify where errors are happening, from a high-level perspective (frontend, browser; or backend, node).

on-error-client, in the plugin, only captures exceptions if the error is an actual Error. Some errors are launched with missing data (for example, no stack trace), and what users see in the issue is misleading. In those cases, instead of capturing the exception itself, what's being captured (as a message) is the error message, so that it still reaches the issue list but doesn't contain random data.

@iker-barriocanal iker-barriocanal requested review from lobsterkatie and a team March 15, 2021 12:19
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.28 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.18 KB (0%)
@sentry/react - Webpack 21.22 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.36 KB (+0.01% 🔺)

@rhcarvalho
Copy link
Contributor

rhcarvalho commented Mar 22, 2021

@iker-barriocanal please document (in the PR description) why are we adding the new tags -- that helps us understand how code got to be the way it is in the future.

@iker-barriocanal iker-barriocanal merged commit 61e401d into feat/next-js Mar 24, 2021
@iker-barriocanal iker-barriocanal deleted the feat/next-js-plugin-errors branch March 24, 2021 16:13
@iker-barriocanal iker-barriocanal changed the title feat: Add runtime tags to errors feat: Add runtime tags to Next.js errors Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants