fix possible ie8 trailing comma problem #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, damn. Any idea why the linter didn't pick that up in the first place? |
mattrobenolt
added a commit
that referenced
this pull request
Mar 18, 2015
fix possible ie8 trailing comma problem
mattrobenolt
added a commit
that referenced
this pull request
Mar 18, 2015
|
Ok, apparently jshint does not check for that by default. :/ http://jslinterrors.com/extra-comma Added. |
|
Also, just verified, and this would have only affected the unminified builds. Uglify does the right thing and fixed the trailing comma when minifying for the Going to push a version bump for this regardless, thanks. 🍰 ✨ |
matghaleb
pushed a commit
to matghaleb/raven-js
that referenced
this pull request
Sep 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced with exception on 678 string of raven.js with IE versions less than 8 and below. Google Closure Compiler thrown errors too...
This fixes the issue. All tests passed, full build successful too.
Thanks.