Skip to content

Improve isString to cover String objects #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2015
Merged

Improve isString to cover String objects #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/raven.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ function isFunction(what) {
}

function isString(what) {
return typeof what === 'string';
return objectPrototype.toString.call(what) === '[object String]';
}

function isObject(what) {
Expand Down
2 changes: 2 additions & 0 deletions test/raven.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ describe('globals', function() {
describe('isString', function() {
it('should do as advertised', function() {
assert.isTrue(isString(''));
assert.isTrue(isString(String('')));
assert.isTrue(isString(new String('')));
assert.isFalse(isString({}));
assert.isFalse(isString(undefined));
assert.isFalse(isString(function(){}));
Expand Down