fix(nextjs): Fix ember tests on CI #3360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iker-barriocanal
changed the title
size-limit report
|
iker-barriocanal
requested review from
a team,
ahmedetefy and
lobsterkatie
and removed request for
a team
|
Why not merge master into the feature branch instead? |
|
As a general advice, we should be keeping long-lived feature branches up-to-date otherwise it could be unnecessarily difficult and error prone to eventually merge them back into master. |
|
Closing in favor of #3362. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember tests are failing on CI. They've been fixed on master on defce67, and this is the same fix for the Next.js branch.