feat: Honor no_proxy env variable #3412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
requested review from
a team,
lobsterkatie and
iker-barriocanal
and removed request for
a team
size-limit report
|
iker-barriocanal
approved these changes
Apr 21, 2021
packages/node/src/transports/base.ts
Outdated
| @@ -70,6 +70,26 @@ export abstract class BaseTransport implements Transport { | |||
| return this._buffer.drain(timeout); | |||
| } | |||
|
|
|||
| /** Extracts proxy settings from client options and env variables */ | |||
There was a problem hiding this comment.
Should we include in the docstring that if HTTP proxy is not found, it looks for the HTTPS proxy?
iker-barriocanal
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3122
Based on the
sentry-pythonimplementation https://github.com/getsentry/sentry-python/blob/4c09f3203d6d19789c6fa729a2e46557ad4ea913/sentry_sdk/transport.py#L279-L314 and GitLabs write-up https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/