-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(nextjs): Catch exceptions when syncing plug-in's version #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please summarize the issue in a sentence or two in the PR description, so someone coming here can have at least a little context without having to click through to the issue?
Hey @iker-barriocanal, thanks for looking into this.
Can you expand on what you mean here? What am I supposed to do here? I'm using Vercel's Github Integration which makes it so that Vercel builds the project for me and then deploys. There's nothing for me to do there. Will that work? I believe most people use Vercel that way. |
I believe we're going to have to address this another way, given that workflow. We're working on it and will keep you posted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this - it's a good change just for safety's sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching it is better than failing a deploy, although it's not clear what the user would need to do when this happens.
@lobsterkatie cool, this is the only thing holding me back from using I'll do some other work in the meantime while waiting for this, since I think the (future) benefits of using All the best, |
If this happens, the plug-in's version doesn't match with the nextjs' version. Building the project locally, where the |
I know what will happen, but the user might not understand that based solely on that one console log :P |
@kamilogorek message updated. |
Fixes #3441
Vercel's file system is read-only, so it throws an exception when trying to rewrite the plugin's version. This happens in runtime in every request in serverless environments.
Users are supposed to build the app before deploying it to Vercel (where the file system isn't read-only), since the plugin version must still be sync-ed.