Ember: Remove @embroider/test-setup Dependency
#3460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `yarn.lock` on `master` seems to be in an invalid state; these changes happen by just running `yarn install` without even changing any of the `package.json` files.
This package is only used for testing purposes, and should not be a dependency of an Ember addon.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).The
@embroider/test-setuppackage should be a development dependency rather than a "normal" one, since it's only used for testing purposes. The current state of the package means that the package is added to my own app when I install the@sentry/emberpackage, which I do not want.I also noticed that
@embroider/compatwas listed as a dependency but never used, so I removed it. This was likely a holdover from the previous Embroider testing approach, before thetest-setuppackage existed.Running
yarn installonmasterresults in a considerableyarn.lockdiff even without apackage.jsonchange, so I committed those changes separately but have included it in this PR so it's easier to see the actualyarn.lockimpact of removing@embroider/compat.