Skip to content

fix(ember): Fix embroider-safe not working on builds #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2021
Merged

fix(ember): Fix embroider-safe not working on builds #3503

merged 3 commits into from
May 6, 2021

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented May 5, 2021

Summary

Updated and more carefully pinned our ember-source and embroider packages.

@k-fish
fix(ember): Fix embroider-safe not working on builds
511b47c 
Updated and more carefully pinned our ember-source and embroider packages.
@k-fish k-fish requested a review from kamilogorek as a code owner May 5, 2021 17:29
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.63 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.5 KB (0%)
@sentry/react - Webpack 21.53 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.92 KB (-0.01% 🔽)

@k-fish k-fish requested a review from HazAT May 5, 2021 17:59
@k-fish k-fish enabled auto-merge (squash) May 5, 2021 17:59
HazAT
HazAT approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@k-fish k-fish merged commit cbfe9f3 into master May 6, 2021
@k-fish k-fish deleted the fix/ember-builds-embroider-safe branch May 6, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-fish @HazAT