Skip to content

ref(nextjs): Use current hub by default when checking if tracing is enabled #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2021
Merged

ref(nextjs): Use current hub by default when checking if tracing is enabled #3530

merged 2 commits into from
May 12, 2021

Conversation

lobsterkatie
Copy link
Member

This just saves us having to call getCurrentHub()?.getOptions() and checking for the existence of options immediately before every hasTracingEnabled() call.

@lobsterkatie lobsterkatie requested a review from kamilogorek as a code owner May 11, 2021 18:04
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.64 KB (0%)
@sentry/browser - Webpack 21.52 KB (0%)
@sentry/react - Webpack 21.55 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.02 KB (+0.06% 🔺)

@lobsterkatie lobsterkatie mentioned this pull request May 11, 2021
Merged
8 tasks
@HazAT HazAT merged commit 13eea94 into master May 12, 2021
@HazAT HazAT deleted the kmclb-default-hub-for-tracing-enablement-check branch May 12, 2021 07:08
@HazAT HazAT mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobsterkatie @HazAT