Skip to content

ref(nextjs): Make integration utils generic #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2021

Conversation

iker-barriocanal
Copy link
Contributor

There was some code to set a default integration if the user didn't set it up, but it wasn't generic. This PR makes that code more generic to make it reusable (it's meant to be reused in client.config.js, for example).

@iker-barriocanal iker-barriocanal requested a review from a team May 21, 2021 14:54
@iker-barriocanal iker-barriocanal self-assigned this May 21, 2021
@iker-barriocanal iker-barriocanal requested review from ahmedetefy and lobsterkatie and removed request for a team May 21, 2021 14:54
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.76 KB (-0.01% 🔽)
@sentry/browser - Webpack 21.98 KB (0%)
@sentry/react - Webpack 22.01 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.16 KB (-0.01% 🔽)

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had styling/naming nits, much cleaner now 👍

@iker-barriocanal iker-barriocanal enabled auto-merge (squash) May 21, 2021 15:45
@iker-barriocanal iker-barriocanal merged commit 3c0d44e into master May 21, 2021
@iker-barriocanal iker-barriocanal deleted the iker/nextjs-ref-integrations branch May 21, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants