Skip to content

chore(dev): Use Node 14 for development work #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented May 22, 2021

This PR bumps us from Node 10 to Node 14, primarily to get around issues in the VSCode debugger, which won't run under Node 10 anymore.

The one danger in doing so would be that we might use a newer feature of Node which doesn't exist in older versions we're still supporting and doesn't get transpiled down, and not realize we're doing so until it breaks some customer's app. Fortunately, you can tell TS what Node version you're targeting through the use of particular combinations of tsconfig settings. The oldest version for which they have a spec is Node 10, but that's what we've been using all along anyway. Fortunately, according to that list, all of our current settings already fulfill the requirements.

@lobsterkatie lobsterkatie requested a review from kamilogorek as a code owner May 22, 2021 03:57
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.76 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.98 KB (0%)
@sentry/react - Webpack 22.01 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.16 KB (+0.01% 🔺)

Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's a risk of doing that, as we run all our builds and tests on multiple node versions anyway.

@lobsterkatie lobsterkatie merged commit 4b7edf2 into master May 24, 2021
@lobsterkatie lobsterkatie deleted the kmclb-use-node-14 branch May 24, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants