fix(angular): prevent memory leak when the root view is removed #3594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).The
TraceService
creates multiple subscriptions torouter.events
and never unsubscribes. The root view may be created and destroyed many times in different cases:AppModule
is bootstrapped and destroyed throughNgModuleRef.destroy()
whenever the app should be rendered or destroyed)In the above cases, this keeps creating the
TraceService
for each new app, but it also prevents many resources from being GC'd, for instanceTraceService
,AppModule
(since its injector keeps the reference),Router
, etc.