Skip to content

ref: Remove event from EventType type #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2021
Merged

ref: Remove event from EventType type #3678

merged 2 commits into from
Jun 15, 2021

Conversation

kamilogorek
Copy link
Contributor

https://develop.sentry.dev/sdk/event-payloads/types/#eventtype
https://develop.sentry.dev/sdk/envelopes/#data-model

EventType = "default" | "error" | "transaction"
ItemType = "event" | "transaction"

These are two different things apparently.

@kamilogorek kamilogorek requested a review from rhcarvalho June 15, 2021 09:14
@kamilogorek kamilogorek enabled auto-merge (squash) June 15, 2021 09:17
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.98 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.85 KB (0%)
@sentry/react - Webpack 21.89 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.37 KB (0%)

@kamilogorek kamilogorek requested review from a team and lobsterkatie and removed request for a team June 15, 2021 09:46
@kamilogorek kamilogorek disabled auto-merge June 15, 2021 09:46
@kamilogorek kamilogorek enabled auto-merge (squash) June 15, 2021 09:46
@kamilogorek kamilogorek merged commit e9c6d6a into master Jun 15, 2021
@kamilogorek kamilogorek deleted the correct-event-type branch June 15, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@rhcarvalho rhcarvalho Awaiting requested review from rhcarvalho

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilogorek @AbhiPrasad