fix(react): Require ReactElement in ErrorBoundary props and render #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2021
AbhiPrasad
reviewed
Aug 3, 2021
| } | ||
|
|
||
| // Fail gracefully if no fallback provided | ||
| // Fail gracefully if no fallback provided or is not valid |
There was a problem hiding this comment.
We can use logger from @sentry/utils to log out a warning here: https://github.com/getsentry/sentry-javascript/blob/master/packages/utils/src/logger.ts
import { logger } from `@sentry/utils`
jcomo
changed the title
|
@AbhiPrasad should be all set for a final pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ErrorBoundary fallback type in @sentry/react to require a ReactElement. This addresses the inconsistency in #3828
Open question: in the case where the fallback prop is not a valid element, I wanted to include some sort of console warning so that the developer can get feedback (really only matters for js). This would have saved us an hour of debugging and sifting through the SDK source code. However, the linter doesn't allow console.log statements -- what's the preferred approach? We can ignore the linter for that line, leave it out entirely, or follow some warning convention if it exists in the codebase.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).