Strip device-specific paths/urls from react native paths #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
force-pushed
the
normalize-react-paths
branch
2 times, most recently
from
d5b8ac0 to
00ac0b7
Compare
| "use strict"; | ||
|
|
||
| return url | ||
| .replace(/file\:\/\//, '') |
There was a problem hiding this comment.
Should qualify this with a ^ so it doesn't replace this randomly in the string.
benvinegar
force-pushed
the
normalize-react-paths
branch
from
00ac0b7 to
7f6d414
Compare
benvinegar
added a commit
that referenced
this pull request
Oct 29, 2015
Strip device-specific paths/urls from react native paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes grouping work / paths actually readable inside Sentry.