Skip to content

ref(gatsby): Remove default Gatsby SDK options #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

iker-barriocanal
Copy link
Contributor

Follow-up to #4040. Removing the two Gatsby SDK default options because:

  • autoSessionTracking is redundant, enabled by default since v6.
  • environment should be undefined if not set by the user.

@types/node is only used to make the linter happy with process (when setting the environment in the default options). Since these are being removed, this dev dep is no longer required.

@iker-barriocanal iker-barriocanal requested a review from a team October 11, 2021 08:18
@iker-barriocanal iker-barriocanal self-assigned this Oct 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.33 KB (0%)
@sentry/browser - Webpack 23.31 KB (0%)
@sentry/react - Webpack 23.34 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.79 KB (0%)

@iker-barriocanal iker-barriocanal enabled auto-merge (squash) October 11, 2021 12:39
@iker-barriocanal iker-barriocanal merged commit faf6717 into master Oct 11, 2021
@iker-barriocanal iker-barriocanal deleted the iker/ref/gatsby-default-opts branch October 11, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants