fix(nextjs): Add sideEffects flag to NextJS SDK #4216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have side effects in `index.server.ts`, so we mark as such in our package.json.
size-limit report
|
lobsterkatie
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
LGTM.
I desperately wish they'd finally get around to letting you use comments in package.json... At some point, we might revisit this, because I suspect that long term, this is going to depend on whether or not you're deployed to vercel and/or whether or not you're using tracing. But that's a bridge to cross a different day.
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
We have side effects in `index.server.ts`, so we mark as such in our package.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have side effects in
index.server.ts, so we mark as such in our package.json.